forked from ethereum-optimism/optimism
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Batched commitments #24
Draft
vdrg
wants to merge
14
commits into
develop
Choose a base branch
from
vdrg/batched-commitment-type
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: add test-golang workflow * ci: delete circleci yml file This was used by op, we are moving to using github actions for our fork * ci: fix linter by using golangci-lint action * ci: use golangci-lint v1.61 to match mise.toml requirement * ci: use mise in ci to install correct versions of dependencies * ci: remove setup-go step because go already installed by mise in previous step * ci: build contracts that are needed for op-e2e tests * ci: use caching for forge artifacts * ci: remove slow op-program build don't think we are using it... testing * ci: make go-lint job run in parallel, and update version to try to fix errors * ci: add go modules caching to speed up workflow * ci: add explicit go mod download
…nto vdrg/batched-commitment-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP Implementation of ethereum-optimism/SUPs#1
Includes the changes from ethereum-optimism#12400 in order to consume multiple frames for AltDA channels.
For now, it just uses a bool config flag to determine if it should use batched commitments, and if so it uses 1 frame per commitment (eventually it might need to specify the number of frames per commitment).