Skip to content

Fix the verify job on Ubuntu 26.04 - #24

Closed
laurens-pilot wants to merge 4 commits into
mainfrom
ci/ubuntu-26-04-aom-tools
Closed

laurens-pilot wants to merge 4 commits into
mainfrom
ci/ubuntu-26-04-aom-tools

Conversation

@laurens-pilot

Copy link
Copy Markdown
Owner

Since ubuntu-latest moved to Ubuntu 26.04, the verify job has failed before running any tests. Three things on the new image broke it:

  • Ubuntu's libaom-dev CMake package references aomdec and links libyuv and libwebm, but doesn't install them, so the libheif validator failed to configure and then to link. The job now also installs aom-tools, libyuv-dev and libwebm-dev.
  • The validator build ran make -j with no job limit, and the runner shut down about a minute into compiling. It now builds with one job per CPU.
  • libheif built on the new image fuses its floating-point colour conversion into FMA instructions. The Rust decoder only does that when it is built with FMA, so two files no longer matched the reference pixel for pixel. The validator is now built with -ffp-contract=off, which matches the default x86_64 Rust build.

The job stays on ubuntu-latest.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T13:52:19.887767Z 74c7754 PR opened
🔒 Security Review ✅ Completed 2026-11-16T13:53:46.133065Z 74c7754 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@laurens-pilot

Copy link
Copy Markdown
Owner Author

Superseded by ente#35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants