Desktop: Accessibility: Fixes focus going to start of document when Note History is open #11769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| @@ -92,6 +93,7 @@ const NoteRevisionViewerComponent: React.FC<Props> = ({ themeId, noteId, onBack, | |||
|
|
|||
| setRevisions(revisions); | |||
| setCurrentRevId(revisions.length ? revisions[revisions.length - 1].id : ''); | |||
| focus('NoteRevisionViewer::viewer_domReady', viewerRef.current); | |||
There was a problem hiding this comment.
Thank you for working on this! To prevent the autofocus from being removed in the future, consider adding a comment explaining why this autofocus is necessary.
(Optional): It may make more sense for focus to initially jump to the revisions dropdown menu.
laurent22
reviewed
Feb 6, 2025
| @@ -180,6 +182,12 @@ const NoteRevisionViewerComponent: React.FC<Props> = ({ themeId, noteId, onBack, | |||
|
|
|||
| const viewer = <NoteTextViewer themeId={themeId} viewerStyle={{ display: 'flex', flex: 1, borderLeft: 'none' }} ref={viewerRef} onDomReady={viewer_domReady} onIpcMessage={webview_ipcMessage} />; | |||
|
|
|||
| React.useEffect(() => { | |||
There was a problem hiding this comment.
No React.useEffect please - just useEffect
| @@ -180,6 +182,12 @@ const NoteRevisionViewerComponent: React.FC<Props> = ({ themeId, noteId, onBack, | |||
|
|
|||
| const viewer = <NoteTextViewer themeId={themeId} viewerStyle={{ display: 'flex', flex: 1, borderLeft: 'none' }} ref={viewerRef} onDomReady={viewer_domReady} onIpcMessage={webview_ipcMessage} />; | |||
|
|
|||
| React.useEffect(() => { | |||
| // We need to force focus here because the otherwise the focus is lost and goes back | |||
There was a problem hiding this comment.
Suggested change
| // We need to force focus here because the otherwise the focus is lost and goes back | |
| // We need to force focus here because otherwise the focus is lost and goes back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10795
Summary
Previously when opening the Note History the focus of the page would go back to the start of the document. Here I'm using the
focusutility to set it programmatically to the content of the Note History screen.WCAG
Guideline 2.4.3. Focus Order
Testing