Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Accessibility: Make it possible to create and edit profiles with a screen reader #11797

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Feb 7, 2025

Summary

This pull request improves the accessibility of the profile switcher screen.

In particular, it:

  1. Labels the "add profile" button.
  2. Exposes the long-press action on profile list items to screen readers.
  3. Exposes which profile is selected to screen readers.

See also #11661.

Testing plan

Android 13:

  1. Enable TalkBack.
  2. Open the profile configuration screen (in an app with multiple profiles, a non-default profile selected).
  3. Move TalkBack focus to the first profile.
  4. Verify that TalkBack reads "Default, Button", then "double-tap to activate", then "double-tap and hold to edit".
  5. Double-tap and hold.
  6. Verify that TalkBack reads "Configuration", then "Edit, button".
  7. Close the dialog.
  8. Move TalkBack focus to the active profile.
  9. Verify that TalkBack describes the profile as "selected".
  10. Move TalkBack focus to the new profile button.
  11. Verify that the button is described as "New profile, button".
  12. Double-tap.
  13. Title the profile "Test".
  • Remaining issue: The React Native Paper edit box's label isn't programmatically associated with the input. TalkBack can read the title, but only when the title itself is focused. The title is next in the focus order after the edit box.
  1. Move focus to the save button and click it.
  2. Move TalkBack focus to the new profile's list item.
  3. Using TalkBack, rename the new profile to "Test 2".
  4. Using TalkBack, delete one of the existing profiles.
  5. Using TalkBack, switch to the just-created "Test 2" profile.

@personalizedrefrigerator personalizedrefrigerator added mobile All mobile platforms accessibility Related to accessibility labels Feb 7, 2025
@laurent22 laurent22 merged commit 2b5881a into laurent22:dev Feb 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to accessibility mobile All mobile platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants