Open
Conversation
ecolban
commented
Aug 19, 2018
ecolban
commented
- Move documentation comments from Robot to RobotInterface.
- Regenerate doc
- Regenerate robot.jar
- Let Driver implement RobotInterface
- Remove WasdKeyboardAdapter since a long press on a letter key brings up a menu on MacOS, thus making it impractical to use letter keys to control a robot
Needed to lift pen before moving.
setX and setY was automatically setting the pen to down. Now it will retain the pen's position whether it was up or down.
Conflicts: src/org/jointheleague/graphical/robot/Robot.java
setX and setY was automatically setting the pen to down. Now it will retain the pen's position up or down.
If the Robot's first actions were penDown() and turn(), then a line would be drawn from the start from 0, 0 to the robot's start position. That's been fixed. Also the pen width has been clamped to 1 and 10
Moved the League background to the top right corner, made it look better, and resized it nicely.
-Took all image related methods from Robot and put them in RobotImage -Created miniaturize and expand methods so all robots can be miniaturized -added getAverageColor to Util class -added constants to RobotImage to clean up code -some other stuff that I can't remember
-added alpha component to pixels in Util.getAverageColor for better miniaturization -sparkle now works when the robot is static (not moving)
2) Implemented singleton on RobotWindow 3) Corrected a couple of concurrency issues 4) Removed many static and instance variables 5) Removed the Robot.update() method and simplified code 6) Reverted to using the Java API's Image and BufferedImage rather than RobotImage. RobotImage has one static method to load a "robi" file into a BufferedImage, which it returns 7) Removed Util, Vector2D, and Pixel classes
than the more low-level wait-notify mechanism. Hopefully this is more intuitively understandable.
than using the more low level wait/notify mechanism. Other changes are cosmetic.
rotated or miniaturized.
Fixed bug in RobotImage.loadRobi() method which caused loading .robi files from a compressed jar file to fail. Updated Robot.jar
Enhance examples
+ Add new methods lineTo, quadTo, cubicTo, and followPath + Deprecate moveTo and replace by setPos + Add overloaded moveTo to fit in with other path methods + Add new examples
Regenerate jar file Move examples into separate module Update README.md
ecolban
force-pushed
the
master
branch
2 times, most recently
from
9eb812f to
316e81e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.