Add head block validation to forkchoice attestation processing

[bomanaps]

🗒️ Description

Add head block validation to forkchoice attestation processing

🔗 Related Issues or PRs

blockblaz/zeam#315 (comment)

✅ Checklist

• Ran tox checks to avoid unnecessary CI fails:

  uvx --with=tox-uv tox

• Considered adding appropriate tests for the changes.
• Considered updating the online docs in the ./docs/ directory.

[bomanaps]

Opening this PR for discussion, should the spec explicitly require that an attestation’s head.block_root be present in fork choice before validation? it’s not clearly defined in the spec. Would love input on this @g11tech @tcoratger

[tcoratger]

Looks good to me

[bomanaps]

Hello @tcoratger, shouldn’t we change these lines to?

# Line 140:
current_slot = Slot(self.time // INTERVALS_PER_SLOT)

# Line 177:
time_slots = self.time // INTERVALS_PER_SLOT

[tcoratger]

Hello @tcoratger, shouldn’t we change these lines to?

# Line 140:
current_slot = Slot(self.time // INTERVALS_PER_SLOT)

# Line 177:
time_slots = self.time // INTERVALS_PER_SLOT

Not sure what you propose here, you want to change these lines for something else?

[bomanaps]

Hello @tcoratger, shouldn’t we change these lines to?

# Line 140:
current_slot = Slot(self.time // INTERVALS_PER_SLOT)

# Line 177:
time_slots = self.time // INTERVALS_PER_SLOT

Not sure what you propose here, you want to change these lines for something else?

replace SECONDS_PER_INTERVAL with INTERVALS_PER_SLOT. I think we currently calculate slot wrong (4× too high) because self.time is in intervals, not seconds.

[tcoratger]

Ah yes you are right, could you fix this here as well?