Skip to content

feat: Port algebra/monoid.v and algebra/big_op.v#132

Merged
lzy0505 merged 14 commits intoleanprover-community:masterfrom
lzy0505:zliu/algebra-bigop-monoid
Mar 16, 2026
Merged

feat: Port algebra/monoid.v and algebra/big_op.v#132
lzy0505 merged 14 commits intoleanprover-community:masterfrom
lzy0505:zliu/algebra-bigop-monoid

Conversation

@lzy0505
Copy link
Copy Markdown
Collaborator

@lzy0505 lzy0505 commented Jan 26, 2026

Description

Part of #113

  • ported algebra/monoid.v
  • ported big_opL and big_opM parts of algebra/big_op.v

Proofs for some map lemmas are longer than those for their Rocq counterparts because we’re working with generic finite maps while Rocq only uses gmap.

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have updated PORTING.md as appropriate
  • I have added my name to the authors section of any appropriate files

@lzy0505 lzy0505 force-pushed the zliu/algebra-bigop-monoid branch from 60a08c9 to 7b97935 Compare March 2, 2026 23:43
@lzy0505 lzy0505 marked this pull request as draft March 2, 2026 23:44
@lzy0505 lzy0505 marked this pull request as ready for review March 4, 2026 20:04
@lzy0505
Copy link
Copy Markdown
Collaborator Author

lzy0505 commented Mar 5, 2026

I've rebased this PR to use the new FiniteMap API. Can you have a look? @markusdemedeiros
I tried to avoid using ExtensionalPartialMap, which makes some proofs a bit annoying.

@Kaptch Kaptch mentioned this pull request Mar 9, 2026
3 tasks
@markusdemedeiros
Copy link
Copy Markdown
Collaborator

Ok, I'm done! Look over my changes and merge when you are ready.

@lzy0505
Copy link
Copy Markdown
Collaborator Author

lzy0505 commented Mar 16, 2026

Thanks for cleaning up! Looks good to me. Merging now.

@lzy0505 lzy0505 merged commit 5f37138 into leanprover-community:master Mar 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants