Skip to content

feat: Port the map part of bi/big_op.v#191

Merged
markusdemedeiros merged 14 commits intoleanprover-community:masterfrom
lzy0505:zliu/bi-bigop-map
Apr 3, 2026
Merged

feat: Port the map part of bi/big_op.v#191
markusdemedeiros merged 14 commits intoleanprover-community:masterfrom
lzy0505:zliu/bi-bigop-map

Conversation

@lzy0505
Copy link
Copy Markdown
Collaborator

@lzy0505 lzy0505 commented Mar 30, 2026

Description

Part of #113.

Ported big_[and/sep]M.

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have updated PORTING.md as appropriate
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@lzy0505 lzy0505 marked this pull request as ready for review March 30, 2026 22:22
Copy link
Copy Markdown
Collaborator

@markusdemedeiros markusdemedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple changes but overall this looks great

equiv_iff.mp <| bigOpM_sep_zip_equiv Φ₁ Φ₂ hdom

@[rocq_alias big_sepM_impl_strong]
theorem bigSepM_impl_strong [DecidableEq K]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only proof I'd insist be cleaned up before merging, it's very hard to read. Big .trans terms can be changed to calc blocks or refines, non-terminal simps should be squeezed or eliminated. Happy to give it a look myself!

@lzy0505
Copy link
Copy Markdown
Collaborator Author

lzy0505 commented Mar 31, 2026

Thanks for reviewing! I've addressed all comments but the last one on bigSepM_impl_strong. Please give it a look.

@markusdemedeiros markusdemedeiros merged commit 249e233 into leanprover-community:master Apr 3, 2026
1 check passed
@markusdemedeiros
Copy link
Copy Markdown
Collaborator

Merged! bigSepM_impl_strong is indeed pretty hard to clean up. I didn't want to let it block the project any longer so I just broke up those big terms into refine sequences and added a FIXME for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants