feat: Port the map part of bi/big_op.v#191
Merged
markusdemedeiros merged 14 commits intoleanprover-community:masterfrom Apr 3, 2026
Merged
feat: Port the map part of bi/big_op.v#191markusdemedeiros merged 14 commits intoleanprover-community:masterfrom
bi/big_op.v#191markusdemedeiros merged 14 commits intoleanprover-community:masterfrom
Conversation
markusdemedeiros
requested changes
Mar 31, 2026
Collaborator
markusdemedeiros
left a comment
There was a problem hiding this comment.
A couple changes but overall this looks great
src/Iris/BI/BigOp/BigSepMap.lean
Outdated
| equiv_iff.mp <| bigOpM_sep_zip_equiv Φ₁ Φ₂ hdom | ||
|
|
||
| @[rocq_alias big_sepM_impl_strong] | ||
| theorem bigSepM_impl_strong [DecidableEq K] |
Collaborator
There was a problem hiding this comment.
This is the only proof I'd insist be cleaned up before merging, it's very hard to read. Big .trans terms can be changed to calc blocks or refines, non-terminal simps should be squeezed or eliminated. Happy to give it a look myself!
Collaborator
Author
|
Thanks for reviewing! I've addressed all comments but the last one on |
Collaborator
|
Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #113.
Ported big_[and/sep]M.
Checklist
PORTING.mdas appropriateauthorssection of any appropriate filesGenerative AI Guidelines
AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.
havestatements that do not aid readability or code reuse should be inlined.In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.