Skip to content

feat: tactics imod and imodintro support fancy update#194

Merged
MackieLoeffel merged 8 commits intoleanprover-community:masterfrom
HaleOIC:fancyMod
Apr 9, 2026
Merged

feat: tactics imod and imodintro support fancy update#194
MackieLoeffel merged 8 commits intoleanprover-community:masterfrom
HaleOIC:fancyMod

Conversation

@HaleOIC
Copy link
Copy Markdown
Contributor

@HaleOIC HaleOIC commented Apr 2, 2026

Description

  • Complete the fancy update of basic derived laws (BI/Updates.lean)
  • Complete the fancy update instances for updates (ProofMode/InstancesUpdates.lean)
  • Standardizing on %,# and * in iintro/icases Patterns

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have updated PORTING.md as appropriate
  • I have added my name to the authors section of any appropriate files

@HaleOIC HaleOIC marked this pull request as ready for review April 8, 2026 07:20
Copy link
Copy Markdown
Collaborator

@MackieLoeffel MackieLoeffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some small tweaks to the tests and added some small comments, otherwise this PR looks good to me! I asked in #iris-lean > Standardizing on `%`and`#` in `iintro/icases` Patterns @ 💬 if there are objections to the new syntax. Otherwise this is ready to merge once the remaining comments are resolved.

@MackieLoeffel MackieLoeffel merged commit 85cd582 into leanprover-community:master Apr 9, 2026
1 check passed
@HaleOIC HaleOIC deleted the fancyMod branch April 9, 2026 20:24
@HaleOIC HaleOIC restored the fancyMod branch April 9, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants