Conversation
Contributor
|
Preview for this PR is ready! 🎉 (also as a proofreading version). built with commit 6dc5c18. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR emits an error when it detects an
envVarthat is defined more than once. One such case -ELAN_HOMEis now defined only on the Elan page.The
toHtmlimplementation inenvVar.descremits an incorrect ID at the definition site when the variable is defined more than once. For instance, on https://lean-lang.org/doc/reference/latest/Build-Tools-and-Distribution/Lake/#lake-environment, the ToC links toLAKEandELANwork whereasELAN_HOMEgoes to nowhere. Instead of fixing that, I thought it would be cleaner to prohibit duplicates here.