Skip to content

JSX Lab Submission#24

Open
kyleghousel wants to merge 1 commit intolearn-co-curriculum:masterfrom
kyleghousel:submission
Open

JSX Lab Submission#24
kyleghousel wants to merge 1 commit intolearn-co-curriculum:masterfrom
kyleghousel:submission

Conversation

@kyleghousel
Copy link
Copy Markdown

Fixed the JSX in order to pass the tests. Used the tests to guide me.

Comment on lines +5 to +12
return <div id="about">
About
<img src="https://i.imgur.com/mV8PQxj.gif" alt="I made this"></img>
<p></p>
<h2>About Me</h2>


</div>;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch your spacing boss man.

Comment on lines +5 to +10
return <>
<nav>NavBar
<a href="#home">Home</a>
<a href="#about">About</a>
</nav>
</>;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return <>
<nav>NavBar
<a href="#home">Home</a>
<a href="#about">About</a>
</nav>
</>;
return <>
<nav>NavBar
<a href="#home">Home</a>
<a href="#about">About</a>
</nav>
</>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants