Skip to content

Replace Vuetify (VLayout, VBtn) with KDS components in GenericError.vue #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from
Open

Replace Vuetify (VLayout, VBtn) with KDS components in GenericError.vue #5313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d028ba1
Replace Vuetify (VLayout, VBtn) with KDS components in GenericError.vue
Kartikayy007 Aug 21, 2025
cca59b0
Replace KRouterLink with KButton for back navigation in GenericError.vue
Kartikayy007 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 17 additions & 20 deletions contentcuration/contentcuration/frontend/shared/views/errors/GenericError.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,34 @@
<template>

<div>
<AppError>
<StudioAppError>
<template #header>
{{ $tr('genericErrorHeader') }}
</template>
<template #details>
{{ $tr('genericErrorDetails') }}
</template>
<template #actions>
<VLayout
column
align-center
>
<div class="mb-3">
<VBtn
color="primary"
@click="reloadPage"
>
{{ $tr('refreshAction') }}
</VBtn>
<VBtn v-bind="backHomeLink">
{{ $tr('backToHomeAction') }}
</VBtn>
</div>
<KButtonGroup>
<KButton
:primary="true"
:text="$tr('refreshAction')"
@click="reloadPage"
/>
<KButton
Copy link
Member

@rtibbles rtibbles Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To maintain the link-type behaviour here, this needs to be a KRouterLink instead of a KButton, with the backHomeLink object using v-bind instead:


```suggestion
          <KRouterLink
            v-bind="backHomeLink"
            appearance="raised-button"
            :text="$tr('backToHomeAction')"
          />

Alternatively, if that doesn't play nicely with KButtonGroup you can bind the @click event of the KButton to trigger programmatic navigation with Vue Router https://v3.router.vuejs.org/guide/essentials/navigation.html

@click="$router.push(backHomeLink)"

in place of the v-bind.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, ill update it

v-bind="backHomeLink"
:text="$tr('backToHomeAction')"
/>
</KButtonGroup>
<div style="margin-top: 1rem">
<KButton
appearance="basic-link"
:text="$tr('helpByReportingAction')"
@click="showModal = true"
/>
</VLayout>
</div>
</template>
</AppError>
</StudioAppError>
<!-- Modal here -->
<ReportErrorModal
v-if="showModal"
Expand All @@ -45,13 +42,13 @@

<script>

import AppError from './AppError';
import StudioAppError from './StudioAppError';
import ReportErrorModal from './ReportErrorModal';

export default {
name: 'GenericError',
components: {
AppError,
StudioAppError,
ReportErrorModal,
},
props: {
Expand Down