[Remove Vuetify from Studio] Convert Content Library unit tests to Vue Testing Library #5536
+270
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you @vtushar06, within next two weeks, we will assign a reviewer. |
…test cases for selection mode and loading states
Contributor
Author
|
Hii @MisRob, I made some changes as you mentioned in my other PR about testing user-observable behavior instead of implementation details. |
MisRob
reviewed
Nov 18, 2025
...entcuration/contentcuration/frontend/channelList/views/Channel/__tests__/catalogList.spec.js
Show resolved
Hide resolved
MisRob
reviewed
Nov 18, 2025
...entcuration/contentcuration/frontend/channelList/views/Channel/__tests__/catalogList.spec.js
Show resolved
Hide resolved
Contributor
Author
|
@MisRob ,I applied the approach from Issue #5474 and systematically removed stubs that weren't needed.
Tests now focus on user-visible behavior, Now PR is ready for review. |
vtushar06
added a commit
to vtushar06/studio
that referenced
this pull request
Nov 20, 2025
…n from unstable The contributor's StudioChip implementation is identical to ours. We'll use their version from unstable and focus on test refactoring following Issue learningequality#5536 patterns (data-present vs data-absent scenarios). Following maintainer guidance from PR learningequality#5540 review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor Content Library (CatalogList) tests from Vue Test Utils to Vue Testing Library, following VTL best practices of testing user-observable behavior instead of implementation details.
Changes:
mount()+ internal state testing torender()+screen+userEventTest coverage:
Verification:
Ran npm test -- catalogList.spec.js
It passed all 15 tests
…
References
Closes: #5527
…
Reviewer guidance
Tests focus on rendered content + business logic (VTL pattern)
No internal state access (removed tests on excluded array, component methods)