Prevent and handle IntegrityErrors during user creation #5582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanOXDi
reviewed
Dec 4, 2025
Member
AllanOXDi
left a comment
AllanOXDi
left a comment
There was a problem hiding this comment.
I have tested it manually, and it fixes the problem, but I have one ' what if' concern about exception handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds extra handling for potential IntegrityError when attempting to create a user
Adds frontend submission blocking
Adds a backend test and frontend test for each behaviour
Fixed a typo in the backend tests for user registration (
paswordinstead ofpassword)References
Fixes #4779
Reviewer guidance
🤖 This was created by Claude Code. @rtibbles then reviewed the generated output, and did iterative rounds of updates before making it ready for review 🤖
Manual tests:
Load the account creation page
Turn network throttling on in the Network tab of the browser
Create an account and try to click the submit button multiple times
To make absolutely sure of the backend fix you can also disable the 'submission prevention' code in the frontend, then do the same just to test the backend - I was not able to replicate the 500 from the Sentry error doing this, even without the fixes, but I suspect this may be because of the single threaded devserver environment.