Fix leaking nounset in deploy activation scripts#115
Merged
Conversation
amacati
approved these changes
Jul 1, 2026
Collaborator
|
Thanks Radu! |
aloisi101-bit
pushed a commit
to aloisi101-bit/lsy_drone_racing
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
pixi shell -e deployactivation by removing nounset fromtools/setup_acados.sh. The root cause was that Pixi sources activation hooks into a shared shell, soset -uleaked fromsetup_acados.shinto later hooks; whentools/setup_mocap.shthen sourced ROS/colcon’s generatedros_ws/install/setup.sh, it failed withCOLCON_CURRENT_PREFIX: unbound variablebecause that script expects the variable to be allowed to be unset. This change keeps the activation behavior compatible with downstream ROS setup while preserving the intended setup flow.Fixes #113