Add warning for controller execution time exceeding loop frequency in sim#119
Merged
Merged
Conversation
ratheron
requested changes
Jul 14, 2026
ratheron
left a comment
ratheron
left a comment
Collaborator
There was a problem hiding this comment.
Why not keep it simpler?
Collaborator
|
Since multiple teams this term noticed towards the end that their control approach is not feasible in real due to recomputation, I think this PR helps with that. What do you think @amacati |
Collaborator
|
Seems very useful, thanks. @ratheron Looking at the review, why not measure |
ratheron
requested changes
Jul 14, 2026
Collaborator
|
You are right, was unintentional. I adjusted my review |
Co-authored-by: Marcel Rath <75042654+ratheron@users.noreply.github.com>
amacati
approved these changes
Jul 14, 2026
amacati
left a comment
amacati
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks for the addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mirroring deploy.py, the sim will now also shows warning message if the control exceeds loop frequency