Skip to content

fix: filter framework to prebuild for which marked as binary => false #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: filter framework to prebuild for which marked as binary => false #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/cocoapods-binary/Prebuild.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,16 @@ def prebuild_frameworks!
targets = self.pod_targets
end

targets = targets.reject {|pod_target| sandbox.local?(pod_target.pod_name) }

# frameworks which mark binary true, should be filtered before prebuild
prebuild_framework_pod_names = []
podfile.target_definition_list.each do |target_definition|
next if target_definition.prebuild_framework_pod_names.empty?
prebuild_framework_pod_names += target_definition.prebuild_framework_pod_names
end

targets = targets
.reject {|pod_target| sandbox.local?(pod_target.pod_name) }
.select {|pod_target| prebuild_framework_pod_names.include?(pod_target.pod_name) }

# build!
Pod::UI.puts "Prebuild frameworks (total #{targets.count})"
Expand Down