feat: rewrite to full node runner#2
Merged
Conversation
|
Caution Accessibility issues were detected in this PR. Please fix them before merging. The following routes have violations: |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of using separate steps, we use one main script to improve readability.
The advantage is that we can directly manage the github artifacts, no longer needing to duct-tape a secondary action to our action.
The disadvantage is that we no longer can use other actions in our action, since the action is no longer composite.
This PR also improves management of the pnpm setup by requiring this to be done in the parent workflow. This is now documented.
Since a lot was rewritten, I took the time to clean up some things, mainly clean code stuff and some security.
Checklist
Version Bump
patch– bug fixes, documentation updates, minor improvements (default)minor– new features or notable changes (backwards compatible)major– breaking changes