fix: use stellar keys generate --overwrite to handle existing identities#444
Merged
Conversation
The 'stellar keys rm ... || true' + 'stellar keys generate' pattern fails in CI when the identity already exists because rm output goes to stdout (not stderr), so '2>/dev/null' does not suppress the error, and config-dir differences between calls can leave the key in place. stellar-cli v26 --overwrite atomically replaces any existing identity, removing the need for a separate rm step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'stellar keys rm ... || true' + 'stellar keys generate' pattern fails in CI when the identity already exists because rm output goes to stdout (not stderr), so '2>/dev/null' does not suppress the error, and config-dir differences between calls can leave the key in place.
stellar-cli v26 --overwrite atomically replaces any existing identity, removing the need for a separate rm step.
Summary
Changes
Layer(s) affected
Testing
cargo testpassesnpm run testpasses (api)npm run testpasses (frontend)Checklist
Breaking changes