feat: implement margin and total calculations with tests#63
Merged
Conversation
- Add calculateItemCost, calculateItemRevenue, calculateMargin functions - Add calculateProfitPercentage for profit margin percentage calculation - Add calculateOrderTotals to aggregate order financial metrics - Define OrderTotals interface for aggregated order totals - Implement 33 tests covering all calculation functions with edge cases - TDD approach: red (failing tests) → green (passing code) → refactor Closes #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement business logic for calculations using TDD:
Test Coverage
✅ 33 new tests (all passing)
✅ 103 total tests (all passing)
✅ TDD approach: red → green → refactor
Changes
src/lib/utils/calculations.ts- Implementation of 5 calculation functionssrc/lib/utils/calculations.spec.ts- Comprehensive test suitesrc/lib/types/interfaces.ts- Added OrderTotals interfaceCloses #11