Integrate Speculative Decoding into Lemonade#1638
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Integrates speculative decoding configuration into Lemonade by adding WebUI controls for llama.cpp speculative settings and backend handling to resolve draft model references (checkpoint/model name) into local GGUF paths at load time.
Changes:
- Adds speculative decoding controls (type/presets/advanced flags) to the Model Options modal and new CSS styling for the panel.
- Adds backend logic to normalize/validate
llama-servercustom args: resolve--model-draftto a local GGUF and force--no-mmprojwhen speculative decoding is enabled. - Introduces a
ModelManager::resolve_checkpoint_path()helper to resolve checkpoint strings via recipe-specific path resolution.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/cpp/server/model_manager.cpp | Adds resolve_checkpoint_path() wrapper around recipe path resolution. |
| src/cpp/include/lemon/model_manager.h | Declares the new checkpoint resolution helper API. |
| src/cpp/server/backends/llamacpp_server.cpp | Resolves --model-draft, detects speculative decoding, and forces --no-mmproj when needed. |
| src/app/src/renderer/ModelOptionsModal.tsx | Adds speculative decoding UI/presets and rewrites how model export & submission commits options. |
| src/app/styles.css | Adds styling for the speculative decoding panel layout/responsiveness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Sawan Srivastava <sawan1210@gmail.com>
…del name Signed-off-by: Sawan Srivastava <sawan1210@gmail.com>
Signed-off-by: Sawan Srivastava <sawan1210@gmail.com>
Signed-off-by: Sawan Srivastava <sawan1210@gmail.com>
Signed-off-by: Sawan Srivastava <sawan1210@gmail.com>
Signed-off-by: Sawan Srivastava <sawan1210@gmail.com>
sawansri
force-pushed
the
sawansri/spec-decode-ui
branch
from
368378a to
597b090
Compare
Signed-off-by: Sawan Srivastava <sawan1210@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Sawan Srivastava <sawan1210@gmail.com>
Signed-off-by: Sawan Srivastava <sawan1210@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STILL IN DRAFT
Resolves #1419
Adds UI controls for speculative decoding
Also includes logic in backend to resolve model paths if checkpoint/model name is given.
This enables creating recipes with draft models (paths are not user specific and instead get resolved by lemonade)