Skip to content

va: Avoid creating multiple slow remote timers in doRemoteOperation #8516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aaomidi wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

va: Avoid creating multiple slow remote timers in doRemoteOperation #8516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion va/va.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,7 @@ func (va *ValidationAuthorityImpl) doRemoteOperation(ctx context.Context, op rem
var failed []string
var passedRIRs = map[string]struct{}{}
var firstProb *probs.ProblemDetails
var slowTimerSet bool

for resp := range responses {
var currProb *probs.ProblemDetails
Expand Down Expand Up @@ -606,13 +607,14 @@ func (va *ValidationAuthorityImpl) doRemoteOperation(ctx context.Context, op rem
firstProb = currProb
}

if va.slowRemoteTimeout != 0 {
if va.slowRemoteTimeout != 0 && !slowTimerSet {
// If enough perspectives have passed, or enough perspectives have
// failed, set a tighter deadline for the remaining perspectives.
if (len(passed) >= required && len(passedRIRs) >= requiredRIRs) ||
(len(failed) > remoteVACount-required) {
timer := time.AfterFunc(va.slowRemoteTimeout, cancel)
defer timer.Stop()
slowTimerSet = true
}
}

Expand Down
Loading