fix(skills): correct stale system-prompt claim in managing-shared-memory - #4323
Draft
amelia-letta wants to merge 1 commit into
Draft
amelia-letta wants to merge 1 commit into
amelia-letta wants to merge 1 commit into
Conversation
Shared memory repositories are projected into the agent's system prompt (path plus top-level files, refreshed on recompile), per the official docs and the server-side projection. The skill claimed shared memory is not part of the system prompt, contradicting its own attach description. Builtin-skill-watch: managing-shared-memory@de54f4a461b6-7496f1fbb7a9acd9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builtin-skill-watch: managing-shared-memory@de54f4a461b6-7496f1fbb7a9acd9
Summary
Audit of the
managing-shared-memorybuiltin skill found one stale claim:<shared_memory>section, refreshed on recompile. The skill itself already says attach "recompiles the system prompt projection", so the bullet also contradicted its own attach description.Evidence:
renderAttachedRepositoriesProjectionin letta-cloud (libs/service-core-runtime/src/lib/core-runtime/systemPrompt/pierreRendering.ts) renders the<shared_memory>block with the repository location and rootMEMORY.mdcontent (or top-level file tree) into the system prompt.Change
Smallest truthful update to the one stale bullet; the operative guidance (writing to shared memory does not change in-context memory) is preserved:
Validation
bun test src/agent/skills-agent-availability.test.ts src/cli/subcommands/shared-memory.test.ts src/agent/attached-repository-git-sync.test.ts— 27 passbun run check— 12/12 pass$MEMORY_DIR/../<name>, post-turn push with rebase-retry-once, sync error messages, cross-agent guard, SDK surface) verified against current source and docs