fix(context-doctor): remove incorrect persona.md and overlap claims - #4348
Draft
amelia-letta wants to merge 1 commit into
Draft
amelia-letta wants to merge 1 commit into
amelia-letta wants to merge 1 commit into
Conversation
The skill incorrectly stated that persona.md is a required root file and that overlapping file/folder names are prohibited. Neither claim is enforced by the memory constraints validator. - Remove persona.md requirement from ROOT_MEMORY.md and SKILL.md - Remove overlap prohibition claim from ROOT_MEMORY.md and SKILL.md - The validator only requires MEMORY.md for MemFS v2 Builtin-skill-watch: context-doctor@9ead5f0480b2-aec3edebbc10e4e4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builtin-skill-watch: context-doctor@9ead5f0480b2-aec3edebbc10e4e4
Selected skill
context-doctor- Identify and repair degradation in system prompt, external memory, and skills preventing you from following instructions or remembering information as well as you should.Stale claims
persona.mdis a required root file alongsideMEMORY.mdCurrent owning source
src/agent/memory-constraints.tsandsrc/memory-constraints.ts- The memory constraints validator only requiresMEMORY.mdfor MemFS v2 (API-backed memory). Neitherpersona.mdnor overlap prohibition is enforced by the validator.Validation performed
memory-constraints.tsfor persona validation: none foundmemory-git-hooks.tsfor overlap validation: none foundmemory-format.ts: only checks forMEMORY.mdmarkerbun run check: all 12 checks pass🏥