docs(skills): fix stale tool conversation handle claim in creating-mods - #4360
Draft
amelia-letta wants to merge 1 commit into
Draft
amelia-letta wants to merge 1 commit into
amelia-letta wants to merge 1 commit into
Conversation
Tools receive the full scoped conversation handle (fork, sendMessageStream, updateTitle, updateLlmConfig), not just getHistory. The old claim that tools lack fork/send helpers no longer matches src/tools/manager.ts, which builds the complete createModConversationHandle for tool run contexts. Builtin-skill-watch: creating-mods@de54f4a461b6-34f18e9b25b017bd Co-Authored-By: Letta Code <noreply@letta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
references/architecture.mdthat mod tools "receivectx.conversation.getHistory()but not fork/send helpers"Stale claim and current owning source
src/tools/manager.ts(~line 2172) builds the fullcreateModConversationHandle(...)for mod tool run contexts, so tools receive the same scopedctx.conversationhandle as commands and events:fork,getHistory,sendMessageStream,updateTitle, andupdateLlmConfig(src/mods/conversation-handle.ts,ModToolRunContext.conversation: ModConversationHandleinsrc/mods/types.ts:579-586).Scope note
This PR intentionally does not touch
turn_end/"reload"/alwaysAskdrift: open watcher PR #4118 already covers those findings for this skill; no duplication per watcher rules.Focused validation
bun run checkpasses (12/12 checks)src/skills/builtin/creating-mods/references/)Builtin-skill-watch: creating-mods@de54f4a461b6-34f18e9b25b017bd
Test plan
bun run checkpasses👾 Generated with Letta Code
Co-Authored-By: Letta Code noreply@letta.com