fix(skills): use real --output-format flag in messaging-agents - #4367
Draft
amelia-letta wants to merge 1 commit into
Draft
amelia-letta wants to merge 1 commit into
amelia-letta wants to merge 1 commit into
Conversation
The skill told agents to run `letta -p ... --output json`, but the CLI flag catalog only defines `--output-format`; strict parsing rejects `--output` with "Unknown option". Point the JSON response example at the real flag and prefer `messages transcript` for full-transcript pulls. Also lock the documented headless flags behind a skill test so a stale flag reference fails CI instead of reaching agents. Builtin-skill-watch: messaging-agents@aa3e294d006b-a29c6f40c6ffdc12 Co-Authored-By: Letta Code <noreply@letta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messaging-agentsskill told agents to runletta -p ... --output json, but the CLI flag catalog only defines--output-format; strict parsing rejects--outputwithUnknown optionletta messages list, butmessages transcriptis the command that renders tool calls;messages listreturns raw JSON messagessrc/skills/messaging-agents.test.tslocking the documented headless flags to the CLI flag catalog so a stale flag reference fails CIBuiltin-skill-watch: messaging-agents@aa3e294d006b-a29c6f40c6ffdc12
Selected skill
src/skills/builtin/messaging-agentsStale claim and current owning source
--output json(SKILL.md line 105) vssrc/cli/args.tsCLI_FLAG_CATALOG(output-format, nooutputalias) andsrc/index.tsstrictparseCliArgs(processedArgs, true)letta messages list --agent <id>for "full transcript (including tool calls)" vssrc/cli/subcommands/messages.ts(transcriptaction renders tool calls;listreturns raw JSON messages)Focused validation
parseCliArgs(["-p","--from-agent","agent-x","--agent","agent-y","--output","json","hi"], strict)fails withUnknown option '--output';--output-format jsonparsesbun test src/skills/messaging-agents.test.ts(2 pass),bun test src/skills/dispatching-coding-agents.test.ts src/agent/skills-discovery.test.ts(18 pass),bun run check(12/12 pass)Test plan
bun run checkpasses--output-formatand rejects--output jsonletta -p --from-agent ... --output-format jsonoutput👾 Generated with Letta Code
Co-Authored-By: Letta Code noreply@letta.com