Conversation
This was referenced Sep 14, 2026
…overy test resolves The test resolved its promise as soon as the final result frame arrived and killed the spawned CLI 500 ms later. The test-home preload removes the temp HOME in afterAll right after the test resolves, while the child still holds files there; on Windows that rm fails with EBUSY (API / windows-latest / 4 on four main pushes 2026-09-13/14). Resolve from the "close" handler instead. Co-Authored-By: Charles Packer <5475622+cpacker@users.noreply.github.com> 👾 Generated with [Letta Code](https://letta.com) Co-Authored-By: Letta Code <noreply@letta.com>
letta-integration
Bot
force-pushed
the
bc4/test-home-cleanup-ebusy
branch
from
September 15, 2026 00:01
46ac002 to
2552099
Compare
This was referenced Sep 15, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API / windows-latest / 4has been failing on main with the same error on four pushes since 2026-09-13 20:53 UTC (889987b, 690c6dd, 232d320, b100c2d) and twice on #4431:The test itself passes.
runLazyRecoveryTestresolved its promise the moment the finalresultframe arrived and scheduledproc.kill()500 ms later. The test-home preload'safterAllrunsrmSync(testHome)as soon as the test resolves, so it races the still-running CLI child, which holds files under that HOME. Windows refuses to remove a directory with open handles; Linux and macOS let it go.Fix: record the outcome when the result frame arrives, but resolve the promise from the child's
closehandler, which fires after the child's stdio has closed. The 500 ms grace-then-kill stays. The fallback for a child that exits on its own (resolve from whatever it produced) is unchanged.Verification
bun run typecheckand biome on the file.--new-agentstartup returns404 Agent not foundunder the sandbox key on main as well), so the live check is this PR'sAPIworkflow, which runs this file on Linux, macOS, and Windows. I will report the Windows shard result.Breadcrumbs
conv-bbe7b4f3-52f5-4aa0-9fe5-6eac06747473API / windows-latest / 4on fix(listener): only the execution owner resumes an interrupted turn on sync [LET-12476] #4431 traced to the same failure on main runs 34782170459, 34788537408, 34789048188, 34791820153.scripts/test-home-preload.tscleanup added in fix(test): isolate user home state #3703; unchanged here.AI Disclosure
AI Tool(s) Used
Letta Code
Human Verification
I have reviewed and understand every change in this pull request and take responsibility for its correctness.