[WIP] StaticCondensation can also be a DofMap #4140
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Coverage, step Generate coverage on 9f452d4 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
lindsayad
changed the title
lindsayad
force-pushed
the
sc-as-dof-map
branch
from
9f452d4 to
496b3ef
Compare
Also, set n components to 0 for DofObjects for the reduced "system"
lindsayad
force-pushed
the
sc-as-dof-map
branch
from
bc6e1f3 to
8e26375
Compare
Mat is a pointer so attempting to mark it as const accomplishes nothing. But we shouldn't penalize users working with a const PetscMatrix and refuse to provide them access to the raw Mat. We will assume that they have good intentions
I wonder whether this is even valid because I don't know if it's guaranteed that the shift in the condensed system would match the shift in the noncondensed system
This reverts commit ea7983b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal is to be able to do field splits on the statically condensed system. This should sit in draft since it has meaningful impacts like converting
DofMapmethods into virtuals until I have some useful demonstration of capability