Polyhedron elements #4150
Open
Polyhedron elements #4150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roystgnr
force-pushed
the
polyhedron_elements
branch
from
8de4d04 to
12ff2f4
Compare
|
Job Coverage, step Generate coverage on 7febf4e wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
roystgnr
force-pushed
the
polyhedron_elements
branch
from
12ff2f4 to
5bd7d4c
Compare
We can't even put a placeholder tet or something here since we can't use nullptr nodes for it.
We're going to need a polyhedron with a center point for more general use, since it turns out that there there are simple faces that can't be tetrahedralized without ending up with degenerate tets
I simplified the Polyhedron work a bit, and the simplification works here too. I got confused by the Polyhedron work a bit, and the comment explains the analogous confusing part.
roystgnr
force-pushed
the
polyhedron_elements
branch
from
5bd7d4c to
7febf4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first half of this could be split out into like 3 other PRs if necessary, but nothing here is an enormous refactor; we already did that for the Polygon phase.
The problem of triangulating a polyhedron with pre-defined side triangulations and without adding a center node ranges from difficult to mathematically impossible, so I'm not sure how useful this first C0Polyhedron subclass is going to be in general, but I'll follow up later with a C0I1Polyhedron where the construction is trivial so we can actually get some work done using these things.