This repository was archived by the owner on Jan 18, 2024. It is now read-only.
fix the filename length and open the Info.plist as binary#3
Open
Rigi wants to merge 39 commits intolibimobiledevice-win32:msvc-masterfrom
Open
fix the filename length and open the Info.plist as binary#3Rigi wants to merge 39 commits intolibimobiledevice-win32:msvc-masterfrom
Rigi wants to merge 39 commits intolibimobiledevice-win32:msvc-masterfrom
Conversation
Rigi
commented
Apr 5, 2018
Rigi
commented
- due to the extra '/' character the trailing zero is replaced
- reading a binary Info.plist stopped at 0x1A character on Windows
…pendency is taken.
…ault). The afc_upload_file function uses 1MB buffers on the stack, so this would cause a stack overflow on Windows if left to the default stack size.
…n would still install eventually, but checking directly after app has terminated would show that the app is not installed) (introduced at commit 19a705e)
- due to the extra '/' character the trailing zero is replaced - reading a binary Info.plist stopped at 0x1A character on Windows
…pendency is taken.
…ault). The afc_upload_file function uses 1MB buffers on the stack, so this would cause a stack overflow on Windows if left to the default stack size.
…n would still install eventually, but checking directly after app has terminated would show that the app is not installed) (introduced at commit 19a705e)
qmfrederik
force-pushed
the
msvc-master
branch
3 times, most recently
from
5ad02af to
68777c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.