Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, config flag macros depending on
SDL_LEAN_AND_MEAN
are always defined, regardless of its value, and only their definedness is checked, not their own values. Those changes fixes this.See 387774a
Fixes #11344
While looking for other issues similar to this, I noticed:
SDL/include/SDL3/SDL_platform_defines.h
Lines 363 to 374 in 8026866
SDL/include/SDL3/SDL_platform_defines.h
Lines 165 to 186 in 8026866
It might be better to always check that config flag macros are defined and true.