Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emscripten: move hints to window properties #12509

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

emscripten: move hints to window properties #12509

wants to merge 13 commits into from
+35 −21

Conversation

Temdog007
Copy link
Contributor

@Temdog007 Temdog007 commented Mar 10, 2025 •
edited
Loading

Move hints used by Emscripten to window properties. This change will be necessary if multiple windows for Emscripten will be supported in the future.

  • Removed hint SDL_HINT_EMSCRIPTEN_CANVAS_SELECTOR
  • Removed hint SDL_HINT_EMSCRIPTEN_KEYBOARD_ELEMENT
  • Added Window Create Property SDL_PROP_WINDOW_CREATE_EMSCRIPTEN_CANVAS_ID
  • Added Window Create Property SDL_PROP_WINDOW_CREATE_EMSCRIPTEN_KEYBOARD_ELEMENT
  • Use hint SDL_HINT_EMSCRIPTEN_CANVAS_SELECTOR as override to SDL_PROP_WINDOW_CREATE_EMSCRIPTEN_CANVAS_ID
  • Use hint SDL_HINT_EMSCRIPTEN_KEYBOARD_ELEMENT as override to SDL_PROP_WINDOW_CREATE_EMSCRIPTEN_KEYBOARD_ELEMENT

@Temdog007
emscripten: move hints to window properties
38a399d 
This change will be necessary if multiple windows for Emscripten will be
supported in the future
@Temdog007
Small fix
ae421a7
@Temdog007 Temdog007 mentioned this pull request Mar 10, 2025
Open
3 tasks
@slouken
Copy link
Collaborator

slouken commented Mar 10, 2025 •
edited
Loading

We should not remove the hints, instead they should be overrides for the properties.

maia-s
maia-s reviewed Mar 11, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slouken slouken slouken left review comments

@bobsayshilol bobsayshilol bobsayshilol left review comments

@maia-s maia-s maia-s left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Temdog007 @slouken @bobsayshilol @maia-s