Restyle message boxes and add icon support to them on X11.

[eafton]

This patch adds an icon (warning, icon, information) to message boxes on the X11 backend.

[eafton]

I have decided to redo the positioning/styling code, any opinions?

[slouken]

I have decided to redo the positioning/styling code, any opinions?

This doesn't add much visual style. Maybe we should use an icon circle background with colors to indicate severity? This more closely matches other platforms.

[eafton]

I have decided to redo the positioning/styling code, any opinions?

This doesn't add much visual style. Maybe we should use an icon circle background with colors to indicate severity? This more closely matches other platforms.

I am looking into it.

[eafton]

I implemented the suggested changes and switched to a circle background, thoughts?

[slouken]

It doesn't look great to me. Maybe it makes sense to build in actual icons?

[eafton]

It doesn't look great to me. Maybe it makes sense to build in actual icons?

What about using coloring the icons in with blue, red, yellow, etc and drawing an outline?

[eafton]

It doesn't look great to me. Maybe it makes sense to build in actual icons?

Is this any better? I think it wouldnt be bad if we used a light color scheme for the widgets.

[eafton]

It doesn't look great to me. Maybe it makes sense to build in actual icons?

What about this?

[slouken]

It doesn't look great to me. Maybe it makes sense to build in actual icons?

What about this?

That's not bad. Can you check other platforms to see what their icons look like? It might be worth checking zenity, as that's closer to what people would expect on Linux.

[eafton]

That's not bad. Can you check other platforms to see what their icons look like? It might be worth checking zenity, as that's closer to what people would expect on Linux.

After checking, I decided to add a small shadow to the icon for increasing contrast, opinions?

[eafton]

@slouken I decided to tweak the palette some more and bevelling to the buttons, thoughts?

[slouken]

This seems fine. @icculus, thoughts?

[eafton]

Sorry to barge in, but I have been working on a fork where all of the window and widget code form the messagebox implementation is moved into a built in toolkit so those functions can be reused in a UNIX non-zenity/non-portal dialog implementation, should I work on that or keep this open?

[eafton]

Sorry to barge in, but I have been working on a fork where all of the window and widget code form the messagebox implementation is moved into a built in toolkit so those functions can be reused in a UNIX non-zenity/non-portal dialog implementation, should I work on that or keep this open?

Thoughts? eafton@1b9eb9d

[slouken]

I'll go ahead and merge this. We can tweak the styling for 3.4.0 release. Thanks for your work on this!

[eafton]

I'll go ahead and merge this. We can tweak the styling for 3.4.0 release. Thanks for your work on this!

@slouken No problem! One last thing, should I work on the "toolkit" mentioned above or not?

[slouken]

I'll go ahead and merge this. We can tweak the styling for 3.4.0 release. Thanks for your work on this!

@slouken No problem! One last thing, should I work on the "toolkit" mentioned above or not?

It's up to you. I don't think it's something SDL would use, we try to minimize system dependencies where possible.

[eafton]

I'll go ahead and merge this. We can tweak the styling for 3.4.0 release. Thanks for your work on this!

@slouken No problem! One last thing, should I work on the "toolkit" mentioned above or not?

It's up to you. I don't think it's something SDL would use, we try to minimize system dependencies where

I'll go ahead and merge this. We can tweak the styling for 3.4.0 release. Thanks for your work on this!

@slouken No problem! One last thing, should I work on the "toolkit" mentioned above or not?

It's up to you. I don't think it's something SDL would use, we try to minimize system dependencies where possible.

Its all internal to SDL, you can check the branch I sent earlier, I split out the code so it can be reused in a dialog subsystem implementation, I also ported messageboxes to it and it seems to work fine.

[slouken]

Oh, I see. Feel free to create a PR for this, sure. I don't know whether it makes sense to use for dialogs, but it doesn't hurt to refactor and clean up the messagebox code.