Fix #3 #4
Open
Fix #3 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will test this once I get home later today with my X220, It should work from the looks of it. Thanks for the PR! :) |
|
On Wed, Jan 17, 2018 at 02:31:46AM +0000, Raphaël Doursenaud wrote:
Commit ee9f6f4 contains a few fixes suggested by CLion static analysis.
Feel free to not include them if you don't feel like it.
Commit 53a17d2 contains the logic changes presented in #3 (comment).
You can view, comment on, or merge this pull request online at:
#4
-- Commit Summary --
* Fixes suggested by CLion static analysis
* Make resolution change more robust
-- File Changes --
M crtc.cpp (82)
M main.cpp (4)
-- Patch Links --
https://github.com/libthinkpad/dockd/pull/4.patch
https://github.com/libthinkpad/dockd/pull/4.diff
I just tested the patch and I experience regression on my system. When
undocking X.Org hangs and when docking I have 2 on, but blank screens.
When undocking it seems like you did not ungrab the screen, and on
docking it's a general mess.
… --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#4
|
smclt30p
reviewed
Jan 17, 2018
| * Step 4: Apply the screen configuration | ||
| * Step 2: Parse the crtc configuration | ||
| * Step 3: Disable all crts | ||
| * Step 4: Resize the screen |
There was a problem hiding this comment.
The screen size must be set AFTER altering the crtc config in any way.
So disable configs, set screen size, enable configs, set screen size
|
Yes, something's wrong even on my system. |
|
On Tue, Jan 30, 2018 at 06:59:19PM -0800, Raphaël Doursenaud wrote:
Yes, something's wrong even on my system.
It was a late night quick and dirty hack ;)
I'll try and have a better look ASAP.
Sure, just send it in.
…
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#4 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ee9f6f4 contains a few fixes suggested by CLion static analysis.
Feel free to not include them if you don't feel like it.
Commit 53a17d2 contains the logic changes presented in #3 (comment).