Update anim.ts #321
Closed
Update anim.ts #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed GitHub issue lichess-org#316, which involved en passant capture animation. Fixes Implemented: 1. Detected en passant capture: The code now identifies when a pawn disappears due to an en passant move. 2. Delayed fading effect: The captured pawn doesn't vanish immediately but fades out smoothly after the animation completes. 3. Proper animation handling: The captured pawn is removed only after the animation finishes, preventing visual glitches. This ensures en passant captures are animated correctly instead of disappearing instantly.
|
Thx @ornicar |
There was a problem hiding this comment.
PR Overview
This pull request updates en passant capture animation handling in anim.ts by introducing a delayed fading effect for captured pawns.
- Added an enPassantFading property and related logic to manage en passant pawn fade-out.
- Updated computePlan and step functions to support the delayed removal of a captured pawn.
Reviewed Changes
| File | Description |
|---|---|
| src/anim.ts | Added en passant fading logic for smooth animation |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
|
I added an example for en-passant to https://github.com/lichess-org/chessground-examples. See the readme to try it with your local chessground. In my tests I couldn't see any difference, and |
|
🤷 Let me know if you want to keep working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed GitHub issue #316, which involved en passant capture animation.
Fixes Implemented:
Detected en passant capture: The code now identifies when a pawn disappears due to an en passant move.
Delayed fading effect: The captured pawn doesn't vanish immediately but fades out smoothly after the animation completes.
Proper animation handling: The captured pawn is removed only after the animation finishes, preventing visual glitches.
This ensures en passant captures are animated correctly instead of disappearing instantly.