Bump LDK Node dependency to fe692f3e397b311489aff8b2dc00761f7d10a69a#183
Conversation
|
I've assigned @benthecarman as a reviewer! |
|
Tests don't compile |
| client_trusts_lsp = false | ||
|
|
||
| # Allow the LSP clients to keep zero channel reserves, i.e., spend their full balance. | ||
| # Note this will potentially allow them to attempt cheating without risking financial penalty, so |
There was a problem hiding this comment.
nit: I find the word "potentially" to actually decrease the communicated level of risk in this sentence. In my mind there is no "potentially", zero-reserve allow free attempts at cheating, full stop :)
Ie say you exhaust your channel balance. Then you broadcast an old state with your balance at eg. 10_000sats. The counterparty claims back the 10_000sats. You've lost no funds in this attempt (it's free). With reserves on, you would have lost 1000 sats.
There was a problem hiding this comment.
Ie say you exhaust your channel balance
Heh, right there you have you're potentiality. I know, splitting hairs, but you started :)
Then you broadcast an old state with your balance at eg. 10_000sats. The counterparty claims back the 10_000sats. You've lost no funds in this attempt (it's free). With reserves on, you would have lost 1000 sats.
Sure, I'll drop the word if you find it makes a huge difference.
There was a problem hiding this comment.
any reason we don't just copy-paste the ldk-node docs/?
There was a problem hiding this comment.
any reason we don't just copy-paste the ldk-node docs/?
Well, for one you had outstanding nits that are might be pending to be addressed in a follow-up, as far as I understood? But, would you prefer that I just 1:1 copy the LDK Node docs?
tnull
force-pushed
the
2026-04-bump-ldk-node
branch
from
449bada to
7f717b8
Compare
Should be fixed. |
|
Need to add |
Signed-off-by: Elias Rohrer <dev@tnull.de>
tnull
force-pushed
the
2026-04-bump-ldk-node
branch
from
7f717b8 to
b48beb4
Compare
Ah, right. |
4 participants
No description provided.