Add splicing RPCs and CLI commands #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

jkczyz wants to merge 6 commits into lightningdevkit:main from jkczyz:2025-10-splicing

Contributor

jkczyz commented Oct 30, 2025

Based on #72.

jkczyz added 4 commits

October 27, 2025 13:36


          Bump the ldk-node dependency

b6cce8c


          f - use PR branch plus cargo update

2759f08


          WIP: Splicing support

963419d


          f - make splice-out address optional

3d93360

ldk-reviews-bot commented Oct 30, 2025 •

edited

Loading

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

jkczyz added this to Weekly Goals

jkczyz self-assigned this

tnull self-requested a review

October 30, 2025 17:39

ldk-reviews-bot commented Nov 3, 2025

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Nov 5, 2025

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.


          f - pass address by reference

4668c28

ldk-reviews-bot commented Nov 8, 2025

🔔 3rd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Nov 10, 2025

🔔 4th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Nov 12, 2025

🔔 5th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.


          f - Bump ldk-node dependency

5a98766

ldk-reviews-bot commented Nov 15, 2025

🔔 6th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot commented Nov 17, 2025

🔔 7th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull reviewed

View reviewed changes

Cargo.lock

    
              version = "2.0.0"

              source = "registry+https://github.com/rust-lang/crates.io-index"

              checksum = "512761e0bb2578dd7380c6baaa0f4ce03e84f95e960231d1dec8bf4d7d6e2627"

              version = 4

Collaborator

tnull Nov 17, 2025

You'll probably have to make the changes on 1.75 to keep the Cargo.lock on version 3 for now. Or, alternatively, check-in an Cargo-minimal.lock that is used in the MRSV CI job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet