-
Notifications
You must be signed in to change notification settings - Fork 408
Client-side of static invoice server #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
valentinewallace
wants to merge
14
commits into
lightningdevkit:main
Choose a base branch
from
valentinewallace:2025-02-static-inv-server-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2c3c72d
Expand MessageForwardNode documentation
shaavan e9f83c8
Refactor: Extract `get_peers_for_blinded_path` helper
shaavan db9bcf6
Introduce `OffersMessageFlow`
shaavan 8d9a6ad
Define blinded path constructors in OffersMessageFlow
shaavan 0abfc99
Implement OffersMessageFlow functions
shaavan 3ad6bba
Introduce flow & usage in ChannelManager
shaavan 69bde76
Add config for paths to a static invoice server
valentinewallace bcbdc7f
Add static invoice server messages and boilerplate
valentinewallace a9de9fb
Track cached async receive offers in offers::Flow
valentinewallace 8e48861
Check and refresh async receive offer
valentinewallace a71b05e
Send static invoice in response to offer paths
valentinewallace e718bce
Cache offer on StaticInvoicePersisted onion message
valentinewallace c2e8b11
Check and refresh served static invoices
valentinewallace 918ed61
Add API to retrieve cached async receive offers
valentinewallace File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good explanation in the commit message. Maybe something can be added to highlight the downside of not having a static invoice server. Suppose the user would just hand over their keysend invoice to the sender or publish it on a website, what goes wrong? I suppose something goes wrong when the paths would need to change?