-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft][Splicing] Add reserve check to splicing #3641
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! I see this is a draft PR. |
Relevant comments from #3407:
Relevant method: |
e34d33c
to
6ec1a19
Compare
…splice_ack messages, but fail afterwards
6ec1a19
to
8ac1467
Compare
Rebased, post #3407. (TODO: review commits, first 2 probably outdated) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3641 +/- ##
==========================================
+ Coverage 89.18% 89.23% +0.05%
==========================================
Files 155 155
Lines 119274 119274
Branches 119274 119274
==========================================
+ Hits 106379 106439 +60
+ Misses 10290 10240 -50
+ Partials 2605 2595 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is a continuation of #3407, adds proper channel balance/reserve check, when handling
splice_ack
(on initiator side).