Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft][Splicing] Add reserve check to splicing #3641

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

optout21
Copy link
Contributor

@optout21 optout21 commented Mar 4, 2025

This is a continuation of #3407, adds proper channel balance/reserve check, when handling splice_ack (on initiator side).

@ldk-reviews-bot
Copy link

👋 Hi! I see this is a draft PR.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@optout21
Copy link
Contributor Author

optout21 commented Mar 4, 2025

Relevant comments from #3407:

Relevant method: check_splice_balances_meet_v2_reserve_requirements

@optout21 optout21 force-pushed the splice-reserve-check branch 2 times, most recently from e34d33c to 6ec1a19 Compare March 4, 2025 19:37
@optout21
Copy link
Contributor Author

optout21 commented Mar 4, 2025

Suggestions implemented; for reserve requirement check, the balance is adjusted with fees and eventual anchor output value (see 6ec1a19).
On hold, waiting for #3407 to land first.

@optout21 optout21 force-pushed the splice-reserve-check branch from 6ec1a19 to 8ac1467 Compare March 8, 2025 07:37
@optout21
Copy link
Contributor Author

optout21 commented Mar 8, 2025

Rebased, post #3407. (TODO: review commits, first 2 probably outdated)

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (4c43a5b) to head (8ac1467).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3641      +/-   ##
==========================================
+ Coverage   89.18%   89.23%   +0.05%     
==========================================
  Files         155      155              
  Lines      119274   119274              
  Branches   119274   119274              
==========================================
+ Hits       106379   106439      +60     
+ Misses      10290    10240      -50     
+ Partials     2605     2595      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants