-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistence test for htlc in the LocalRemoved state #3645
Add persistence test for htlc in the LocalRemoved state #3645
Conversation
👋 Thanks for assigning @valentinewallace as a reviewer! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3645 +/- ##
==========================================
+ Coverage 89.16% 90.25% +1.08%
==========================================
Files 152 155 +3
Lines 118791 127106 +8315
Branches 118791 127106 +8315
==========================================
+ Hits 105921 114715 +8794
+ Misses 10312 9940 -372
+ Partials 2558 2451 -107 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
4d1462b
to
d8754e2
Compare
dea1c86
to
9fc56ac
Compare
9fc56ac
to
42db0df
Compare
Increase coverage and prepare for attributable failures which are going to extend the update_fail_htlc message with an additional field that needs to be persisted as well.
42db0df
to
25a749e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will land after CI passes since this just adds a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very familiar with all the helper functions used here but test lgtm from a LN message flow standpoint 👌
Tests are indeed quite different in LDK compared to LND. There is a lot more manual message passing that needs to happen. But the upside is that the test suite runs incredibly fast. Thanks for taking a look! |
Increase coverage and prepare for attributable failures which are going to extend the update_fail_htlc message with an additional field that needs to be persisted as well (#3611)