Channel Establishment for V3 Channels #3792
Conversation
Useful for the commits that follow where we add more downgrade tests.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
| @@ -16153,22 +16154,28 @@ mod tests { | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_anchors_zero_fee_htlc_tx_fallback() { | |||
| fn test_anchors_zero_fee_htlc_tx_downgrade() { | |||
There was a problem hiding this comment.
Congrats, you touched it, now you get to move it out of channelmanager into some other test-specific file that isn't 15000 lines of code 😂
There was a problem hiding this comment.
Done this in a follow up in #3797 so that move + format can be reviewed separately.
lightning/src/util/config.rs
Outdated
| /// back to a `anchors_zero_fee_htlc` (if [`Self::negotiate_anchors_zero_fee_htlc_tx`] | ||
| /// is set) or `static_remote_key` channel. | ||
| /// | ||
| /// *Implies [`Self::negotiate_anchors_zero_fee_htlc_tx`].* |
There was a problem hiding this comment.
These are in conflict - one says we'll fall back if its set, the other says that its implied (ie always set) if we set this flag.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
✅ Added second reviewer: @valentinewallace |
To allow testing along the way in this PR, turn on negotiation of zero fee channels. Co-authored-by: Matt Corallo <[email protected]>
Sender: MUST set `feerate_per_kw` to zero Receiver: MUST fail the channel if `feerate_per_kw` != 0 Co-authored-by: Matt Corallo <[email protected]>
Like anchor channels, these channels require that the user reserves a UTXO to bump the channel. If we automatically accept this channel type and the user does not have such reserve available, they are at risk of losing funds because they cannot fee bump the channel.
carlaKC
force-pushed
the
3789-channelestablishment
branch
from
3a36506 to
b9ec89c
Compare
|
Removed conflicting docs statement + opened followup for test separation (felt wrong to do move+format in the same PR, happy to include if we want it in here). |
This PR updates the channel establishment flow to allow and validate V3 channels (behind
testflag).