Introduce RenegotiatedFunding monitor update variant #3822
Conversation
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3822 +/- ##
==========================================
- Coverage 89.88% 89.77% -0.11%
==========================================
Files 160 162 +2
Lines 129654 130264 +610
Branches 129654 130264 +610
==========================================
+ Hits 116534 116949 +415
- Misses 10425 10609 +184
- Partials 2695 2706 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
wpaulino
force-pushed
the
renegotiated-funding-monitor-update
branch
from
6c78591 to
ac8c8c5
Compare
This is a new `ChannelMonitorUpdateStep` variant intended to be used whenever a new funding transaction for the channel has been negotiated via the `InteractiveTxConstructor`. This commit primarily focuses on its use for splices, but future work will expand where needed to support RBFs (both for the initial dual funding transaction, and splice transactions). To draw a parallel to channel open, we generally want to have the commitment transactions negotiated for the funding transaction and committed to the respective `ChannelMonitor` before attempting to sign the funding transaction itself. This monitor update fulfills this need for a newly negotiated splice; it includes both the new holder and counterparty commitment transactions, and the new set of applicable `ChannelTransactionParameters`. Once the monitor update has been applied to the monitor and persisted, we allow the release of our `tx_signatures` for the splice transaction to wait for its confirmation.
wpaulino
force-pushed
the
renegotiated-funding-monitor-update
branch
from
ac8c8c5 to
5f0709f
Compare
|
🔔 1st Reminder Hey @TheBlueMatt @jkczyz! This PR has been waiting for your review. |
| fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> { | ||
| write_tlv_fields!(w, { | ||
| (1, self.channel_parameters, (required: ReadableArgs, None)), | ||
| (3, self.current_counterparty_commitment_txid, required), |
There was a problem hiding this comment.
nit: Could we set this to option, and elide the field entirely if it is set to None ?
| let funding_outpoint = funding.channel_parameters.funding_outpoint | ||
| .as_ref().unwrap().into_bitcoin_outpoint(); |
There was a problem hiding this comment.
nit: let funding_outpoint = funding.funding_outpoint().into_bitcoin_outpoint(); ?
| debug_assert!(alternative_htlcs.len() <= current_counterparty_commitment_htlcs.len()); | ||
| for (alternative_htlc, (htlc, _)) in alternative_htlcs.iter().zip(htlcs_with_sources.iter_mut()) { | ||
| debug_assert!(alternative_htlc.transaction_output_index.is_some()); | ||
| debug_assert!(alternative_htlc.is_data_equal(htlc)); |
There was a problem hiding this comment.
nit: I would have also added debug_assert!(htlc.transaction_output_index.is_some()) here to make sure we are not turning a previously dust HTLC into a non-dust HTLC.
This is a new
ChannelMonitorUpdateStepvariant intended to be used whenever a new funding transaction for the channel has been negotiated via theInteractiveTxConstructor. This commit primarily focuses on its use for splices, but future work will expand where needed to support RBFs (both for the initial dual funding transaction, and splice transactions).To draw a parallel to channel open, we generally want to have the commitment transactions negotiated for the funding transaction and committed to the respective
ChannelMonitorbefore attempting to sign the funding transaction itself. This monitor update fulfills this need for a newly negotiated splice; it includes both the new holder and counterparty commitment transactions, and the new set of applicableChannelTransactionParameters. Once the monitor update has been applied to the monitor and persisted, we allow the release of ourtx_signaturesfor the splice transaction to wait for its confirmation.Depends on #3774.