Skip to content

Correct post-update action comment on claims from closed chans #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

Correct post-update action comment on claims from closed chans #3985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lightning/src/ln/channelmanager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8381,11 +8381,11 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
channel_id: Some(prev_hop.channel_id),
};

// Note that we do process the completion action here. This totally could be a
// duplicate claim, but we have no way of knowing without interrogating the
// `ChannelMonitor` we've provided the above update to. Instead, note that `Event`s are
// generally always allowed to be duplicative (and it's specifically noted in
// `PaymentForwarded`).
// We don't have any idea if this is a duplicate claim without interrogating the
// `ChannelMonitor`, so we just always queue up the completion action after the
// `ChannelMonitorUpdate` we're about to generate. This may result in a duplicate `Event`,
// but note that `Event`s are generally always allowed to be duplicative (and it's
// specifically noted in `PaymentForwarded`).
let (action_opt, raa_blocker_opt) = completion_action(None, false);

if let Some(raa_blocker) = raa_blocker_opt {
Expand Down
Loading