make: set CGO_ENABLED=0

[starius]

Make loop and loopd binaries static, more portable.

Binaries built with dynamic dependencies can't be freely moved across machines with different distributions (e.g. NixOS -> Debian breaks because it can't find some libraries).

Pull Request Checklist

• Update release_notes.md if your PR contains major features, breaking changes or bugfixes

[gemini-code-assist]

Summary of Changes

Hello @starius, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the portability of the loop and loopd binaries by ensuring they are built statically. By disabling Cgo during both development and release builds, the binaries will no longer rely on dynamic C libraries, which often cause compatibility issues when moving them between different operating system distributions.

Highlights

• Build Process Enhancement: Modified the Makefile to set CGO_ENABLED=0 for go build and go install commands. This change ensures that local development builds of the project's binaries are statically linked, removing dependencies on system-specific C libraries.
• Release Build Portability: Updated the release.sh script to also set CGO_ENABLED=0 during the official release builds of loop and loopd. This guarantees that the distributed binaries are self-contained and more portable across various Linux distributions and environments, addressing potential issues with dynamic library mismatches.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly implements the goal of creating static Go binaries for better portability by setting CGO_ENABLED=0 in the Makefile and release.sh script. This is a good change for improving the distribution of the loop and loopd executables.

My review includes two main points:

1. A high-severity concern regarding the side effects of disabling Cgo on DNS resolution, which can alter network behavior in subtle but important ways.
2. A medium-severity suggestion to refactor the build commands in release.sh to reduce duplication and improve maintainability.

Overall, the change is beneficial, but the networking implication should be carefully considered.