Remove unnecessary allocations in HopData encode/decode methods #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This PR needs some explanation/rationale for the change it is making. Could you add some comments and/or benchmarks to the PR description and commit message? |
mrekucci
force-pushed
the
remove_unnecessary_allocations_in_hopdata_encode_decode
branch
from
e386a4b
to
b4b6a03
Compare
|
I added the explanation to the commit message. |
By removing io.Writer and io.Reader abstraction from encode and decode
methods, the following benchmars:
old:
func BenchmarkHopDataEncode(b *testing.B) {
hd := new(HopData)
for i := 0; i < b.N; i++ {
hd.Encode(ioutil.Discard)
}
}
type nopReader struct{}
func (nopReader) Read(b []byte) (int, error) { return len(b), nil }
func BenchmarkHopDataDecode(b *testing.B) {
hd := new(HopData)
src := nopReader{}
for i := 0; i < b.N; i++ {
hd.Decode(src)
}
}
new:
func BenchmarkHopDataEncode(b *testing.B) {
hd := new(HopData)
dst := make([]byte, hopDataSize)
for i := 0; i < b.N; i++ {
hd.Encode(dst)
}
}
func BenchmarkHopDataDecode(b *testing.B) {
hd := new(HopData)
src := make([]byte, hopDataSize)
for i := 0; i < b.N; i++ {
hd.Decode(src)
}
}
show the following insrease in performance:
benchmark old ns/op new ns/op delta
BenchmarkHopDataEncode-4 80.7 12.1 -85.01%
benchmark old allocs new allocs delta
BenchmarkHopDataEncode-4 3 0 -100.00%
benchmark old bytes new bytes delta
BenchmarkHopDataEncode-4 24 0 -100.00%
benchmark old ns/op new ns/op delta
BenchmarkHopDataDecode-4 218 9.77 -95.52%
benchmark old allocs new allocs delta
BenchmarkHopDataDecode-4 4 0 -100.00%
benchmark old bytes new bytes delta
BenchmarkHopDataDecode-4 56 0 -100.00%
mrekucci
force-pushed
the
remove_unnecessary_allocations_in_hopdata_encode_decode
branch
from
b4b6a03
to
b1eb2d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.