Skip to content

Conversation

@ziggie1984
Copy link
Collaborator

-Due to a newer version we need to use add_labels instead of just
labels

-The backport PR will now also copy the milestones in case the
milstones were set

@gemini-code-assist
Copy link

Summary of Changes

Hello @ziggie1984, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses minor issues within the backport CI job. It updates the label handling mechanism to align with a newer version's requirements and enhances the backport functionality by ensuring that milestones are correctly propagated to backported pull requests. The changes aim to improve the reliability and completeness of the automated backport process.

Highlights

  • CI Configuration Update: The backport CI job has been updated to use add_labels instead of labels in its configuration, accommodating changes in a newer version of the underlying system.
  • Milestone Propagation: The backport process will now automatically copy any set milestones from the original pull request to the newly created backport pull request.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/backport.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ziggie1984 ziggie1984 self-assigned this Dec 14, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the backport workflow in docs/backport-workflow.md. The change replaces the labels key with add_labels in the example YAML configuration, which is necessary due to a version update as mentioned in the pull request description. The change is correct and improves the accuracy of the documentation. I have no further comments.

-Due to a newer version we need to use add_labels instead of just
 labels

-The backport PR will now also copy the milestones in case the
 milstones were set
@ziggie1984 ziggie1984 force-pushed the bugfix/backport-workflow branch from 157d75a to dbb3a9e Compare December 14, 2025 08:00
@ziggie1984 ziggie1984 marked this pull request as ready for review December 14, 2025 08:00
@ziggie1984 ziggie1984 requested a review from Roasbeef December 14, 2025 08:00
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌀

@Roasbeef Roasbeef merged commit 04f6108 into lightningnetwork:master Dec 15, 2025
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants