-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: ignore Send coverage errors #9508
.github: ignore Send coverage errors #9508
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM 🎉
Sometimes only the "Send coverage" step of a CI job will fail. This commit turns this step into a "best effort" step instead so that it does not block a CI job from passing. It can, for example, often happen that a single job is re-run from the GH UI, it then passes but the "Send coverage" step fails due to the "Can't add a job to a build that is already closed." error meaning that the only way to get the CI step to pass is to re-push and retrigger a full CI run.
00d33d2
to
a67df68
Compare
Sometimes only the "Send coverage" step of a CI job will fail. This commit turns this step into a "best effort" step instead so that it does not block a CI job from passing.
It can, for example, often happen that a single job is re-run from the GH UI, it then passes but the "Send coverage" step fails due to the "Can't add a job to a build that is already closed." error meaning that the only way to get the CI step to pass is to re-push and retrigger a full CI run. (example: https://github.com/lightningnetwork/lnd/actions/runs/13257033750/job/37078871135?pr=9496)