Skip to content

Add support for flags to build on iOS #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: fork
Choose a base branch
from
Open

Add support for flags to build on iOS #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build-tools/build_v8.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ EXTRA_ARGS=""
if [ "${OS}" = "linux" ] && [ "${ARCH}" == "arm64" ]; then
EXTRA_ARGS="clang_base_path=\"/usr/lib/llvm-21\" clang_use_chrome_plugins=false treat_warnings_as_errors=false"
fi
if [ "${OS}" = "ios" ]; then
EXTRA_ARGS="v8_enable_pointer_compression=false v8_enable_webassembly=false"
fi

TARGET_ARCH=${ARCH}
if [ "${ARCH}" = "amd64" ]; then
Expand Down
15 changes: 10 additions & 5 deletions build-tools/utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,13 @@ case $(uname -m) in
*) fail "unsupported architecture: $(uname -m)"
esac

case "$OSTYPE" in
darwin*) OS="mac" ;;
linux*) OS="linux" ;;
*) fail "unsupported platform: ${OSTYPE}"
esac
: "${OS:=unset}"
case "$OS" in
unset)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I got what's wrong: we set the OS w/ macos. I worked before b/c the OS was ignored until this change.

Suggested change
unset)
macos) OS="mac" ;;
unset)

case "$OSTYPE" in
darwin*) OS="mac" ;;
linux*) OS="linux" ;;
*) fail "unsupported platform: ${OSTYPE}"
esac
;;
esac
1 change: 1 addition & 0 deletions build.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ pub fn build(b: *std.Build) !void {
const os = switch (target.result.os.tag) {
.linux => "linux",
.macos => "macos",
.ios => "ios",
else => return error.UnsupportedPlatform,
};

Expand Down