Add getSacBalance to SorobanServer#691
Conversation
30cd755 to
0a8849e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #691 +/- ##
============================================
+ Coverage 80.18% 80.23% +0.05%
- Complexity 1227 1228 +1
============================================
Files 213 213
Lines 4820 4853 +33
Branches 412 413 +1
============================================
+ Hits 3865 3894 +29
- Misses 703 705 +2
- Partials 252 254 +2
🚀 New features to boost your workflow:
|
overcat
left a comment
There was a problem hiding this comment.
👍 It looks great. I have left some minor suggestions for changes.
| import java.util.List; | ||
| import java.util.Optional; | ||
| import java.util.UUID; | ||
| import java.util.*; |
There was a problem hiding this comment.
Please avoid using wildcard imports. I know both have their advantages, but this has been discussed in other PRs before. Since we have a standard now, let's adhere to it.
https://github.com/lightsail-network/java-stellar-sdk/blob/master/CONTRIBUTING.md#code-style
There was a problem hiding this comment.
This is actually from the auto formatter, which is google-java-formatter. What do you think we let the formatter handle this?
There was a problem hiding this comment.
I don't think google-java-formatter does this; are you using IDEA? IDEA does this by default.
https://www.baeldung.com/intellij-disable-wildcard-import
|
🎉 Merged! Thank you for your contribution. |
No description provided.