[mise] Tweak various tasks.
- Remove .mise.toml from js/apps/private/ops, the
#488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `.mise.toml` from js/apps/private/ops, the root scripts will run ops as well. - Renamed `start-<env>` to be `sparkcore-<env>` for consistency. - Added `paycore-dev` to top level to join `paycore-local`. - (Not mise) Fixed `start:minikube` being in the wrong `package.json`. GitOrigin-RevId: 6a081d67c10ef5dded178906f03952a8b983ab1b
Contributor
Author
|
The following public packages have changed files:
There are no existing changesets for this branch. If the changes in this PR should result in new published versions for the packages above please add a changeset. Any packages that depend on the planned releases will be updated and released automatically in a separate PR. Each changeset corresponds to an update in the CHANGELOG for the packages listed in the changeset. Therefore, you should add a changeset for each noteable package change that this PR contains. For example, if a PR adds two features - one feature for packages A and B and one feature for package C - you should add two changesets. One changeset for packages A and B and one changeset for package C, with a description of each feature. The feature description will end up being the CHANGELOG entry for the packages in the changeset. No releases planned. Last updated by commit 680fe18 |
Update public `js` sources with the latest code from the [public repository](https://github.com/lightsparkdev/js-sdk) main branch. This typically happens when new versions of the SDK are released and version updates need to be synced. The PR should be merged as soon as possible to avoid updates to webdev overwriting the changes in the js-sdk develop branch. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Lightspark Eng <[email protected]> Co-authored-by: Corey Martin <[email protected]> GitOrigin-RevId: 8a60f32fae73cd0762928b7eedce2b9c3f87afb3
## Reason We need to validate account numbers because tazapay will not throw if it's invalid. ## Overview - adds frontend validation for account numbers - this PR just adds it for singapore - also updates the singapore bank mapping to its final state - adds popular singapore banks ## Test Plan        GitOrigin-RevId: 9388ac8ad29df7af948bcc7515cf6d6d9af2a9d6
…557) ## Reason Let's make the cookie consent modal a little more friendly looking. Also, we only want to display it to users onboarding in EU, so we check their geoIP before displaying  GitOrigin-RevId: 85d42e1ae623e0fc24ec244a7b386d56ec654fa8
## Reason Explain *why* this change is being made. ## Overview For large or complex changes, describe what is being changed. ## Test Plan Explain how you tested the change. GitOrigin-RevId: b144880a5e8f43cba3348a90ac81b4dacead491c
## Reason Handles scenarios where we want to show sections ## Overview - allows optionally passing either a list of options to SearchSelector or a list of account sections - adds popular banks for philippines - adds "based on your location" section to partner selector - fixes bug where country wasn't being selected correctly because it was using the component prop for the selected region and thus wasn't updating until the parent rerendered - simplifies "filterOptions" to "filterOption" ## Test Plan     - removes section labels if all results filtered out  GitOrigin-RevId: 0e5d5ab6252d86e7df3a2d21bd69859985331d6d
## Reason we need to validate account numbers ## Overview - adds frontend validation for thb account numbers - updates display names for thai banks according to designs (not the bank name we pass to tazapay) - fixes padding for input subtext in bridge  ## Test Plan Explain how you tested the change. GitOrigin-RevId: 319361d02d21004f2c2fbab7e352edcb20be15db
## Reason currency display for BRL didn't include the comma correctly, adding it here additionally, a couple of translations were incorrect and Ive fixed them GitOrigin-RevId: 09be5bdd52fc1f21fba62497a20efe640346f9f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this change should result in new package versions please add a changeset before merging. You can do so by clicking the link provided by changeset bot below.